Introduce prettier as pre-commit (microsoft#5070)

* Pre prettier run setup

* Setup for prettier run

* Prepare utils for clean prettier run

* Fix up code for clean run

* Fix missing key

* Add missing prettier configs

* Prepare experiments for prettier

* Allow lines with 'require' and urls to be longer than 140

* Move prettier to scripts package

* Add prettier run on staged for ts and tsx files

* Add lint staged

* Empty log line

* Add check for changed files

* Add check task

* Support build with lint

* Add code-style command

* Make code-style run

* Lint on CI with fastbuild

* Make sure tslint also runs for apps/<name>

* Fix up formatOnSave

* Minor

* Prettier run

* Change files

* 120 line length

* npm run generate

* Log git diff to check why package changed

* Add prettierignore to ignore package files and js files in lib folders

* Update shrinkwrap

* Minor prettier updates

* Add prettier specific build script

* Add api.ts to prettierignore

* Add ignore file

* Fix prettier option

* Correct ignore path

* More prettier ignore

* Prettify the things

* Fix pre commit

* Remove lint option from travis

Author: Markionium

.prettierignore

@@ -0,0 +1,11 @@
+package.json
+packages/*/package.json
+
+**/*.d.ts
+**/*.api.ts
+
+**/lib/**/*.js
+**/lib-commonjs/**/*.js
+**/dist/*.js
+
+**/CHANGELOG.json

.travis.yml

@@ -7,4 +7,5 @@ script:
     fi
   - npm run buildfast
   - npm run bundlesize
-  - npm run vrtest
+  - npm run vrtest
+  - npm run check-for-changed-files

.vscode/extensions.json

@@ -0,0 +1,8 @@
+{
+  // See http://go.microsoft.com/fwlink/?LinkId=827846
+  // for the documentation about the extensions.json format
+  "recommendations": [
+    // Extension identifier format: ${publisher}.${name}. Example: vscode.csharp
+    "esbenp.prettier-vscode"
+  ]
+}

.vscode/launch.json

@@ -8,14 +8,9 @@
       "program": "${workspaceRoot}/scripts/debug-test.js",
       "cwd": "${fileDirname}",
       "stopOnEntry": false,
-      "args": [
-        "-i"
-      ],
+      "args": ["-i"],
       "runtimeExecutable": null,
-      "runtimeArgs": [
-        "--nolazy",
-        "--debug"
-      ],
+      "runtimeArgs": ["--nolazy", "--debug"],
       "env": {
         "NODE_ENV": "development"
       },
@@ -28,14 +23,9 @@
       "program": "${workspaceRoot}/scripts/build.js",
       "cwd": "${workspaceRoot}/packages/office-ui-fabric-react",
       "stopOnEntry": false,
-      "args": [
-        "ts"
-      ],
+      "args": ["ts"],
       "runtimeExecutable": null,
-      "runtimeArgs": [
-        "--nolazy",
-        "--debug"
-      ],
+      "runtimeArgs": ["--nolazy", "--debug"],
       "env": {
         "NODE_ENV": "development"
       },
@@ -47,17 +37,10 @@
       "request": "launch",
       "program": "${workspaceRoot}/scripts/build.js",
       "stopOnEntry": false,
-      "args": [
-        "webpack",
-        "--",
-        "--production"
-      ],
+      "args": ["webpack", "--", "--production"],
       "cwd": "${workspaceRoot}/apps/fabric-website",
       "runtimeExecutable": null,
-      "runtimeArgs": [
-        "--nolazy",
-        "--debug"
-      ],
+      "runtimeArgs": ["--nolazy", "--debug"],
       "env": {
         "NODE_ENV": "development"
       }
@@ -68,18 +51,10 @@
       "request": "launch",
       "program": "${workspaceRoot}/scripts/build.js",
       "stopOnEntry": false,
-      "args": [
-        "webpack",
-        "--",
-        "--production",
-        "--dogfood"
-      ],
+      "args": ["webpack", "--", "--production", "--dogfood"],
       "cwd": "${workspaceRoot}/apps/fabric-website",
       "runtimeExecutable": null,
-      "runtimeArgs": [
-        "--nolazy",
-        "--debug"
-      ],
+      "runtimeArgs": ["--nolazy", "--debug"],
       "env": {
         "NODE_ENV": "development"
       }
@@ -90,16 +65,10 @@
       "request": "launch",
       "program": "${workspaceRoot}/apps/ssr-tests/node_modules/mocha/bin/_mocha",
       "stopOnEntry": true,
-      "args": [
-        "--debug",
-        "dist/test-bundle.js"
-      ],
+      "args": ["--debug", "dist/test-bundle.js"],
       "cwd": "${workspaceRoot}/apps/ssr-tests",
       "runtimeExecutable": null,
-      "runtimeArgs": [
-        "--nolazy",
-        "--debug"
-      ],
+      "runtimeArgs": ["--nolazy", "--debug"],
       "env": {
         "NODE_ENV": "development"
       },
@@ -112,19 +81,13 @@
       "program": "${workspaceRoot}/scripts/create-component.js",
       "cwd": "${workspaceRoot}",
       "stopOnEntry": false,
-      "args": [
-        "--name",
-        "TestComponentName"
-      ],
+      "args": ["--name", "TestComponentName"],
       "runtimeExecutable": null,
-      "runtimeArgs": [
-        "--nolazy",
-        "--debug"
-      ],
+      "runtimeArgs": ["--nolazy", "--debug"],
       "env": {
         "NODE_ENV": "development"
       },
       "sourceMaps": true
     }
   ]
-}
+}

.vscode/settings.json

@@ -47,4 +47,4 @@
   "editor.formatOnSave": true,
   "typescript.tsdk": "./common/temp/node_modules/typescript/lib",
   "tslint.autoFixOnSave": false
-}
+}

.vscode/tasks.json

@@ -5,13 +5,7 @@
       "label": "Typescript (oufr) watch",
       "type": "process",
       "command": "node",
-      "args": [
-        "./scripts/node_modules/typescript/bin/tsc",
-        "-p",
-        "packages/office-ui-fabric-react/tsconfig.json",
-        "-w",
-        "--noEmit"
-      ],
+      "args": ["./scripts/node_modules/typescript/bin/tsc", "-p", "packages/office-ui-fabric-react/tsconfig.json", "-w", "--noEmit"],
       "problemMatcher": "$tsc",
       "group": {
         "kind": "build",
@@ -22,18 +16,12 @@
       "label": "Typescript (vr-tests) watch",
       "type": "process",
       "command": "node",
-      "args": [
-        "./scripts/node_modules/typescript/bin/tsc",
-        "-p",
-        "apps/vr-tests/tsconfig.json",
-        "-w",
-        "--noEmit"
-      ],
+      "args": ["./scripts/node_modules/typescript/bin/tsc", "-p", "apps/vr-tests/tsconfig.json", "-w", "--noEmit"],
       "problemMatcher": "$tsc",
       "group": {
         "kind": "build",
         "isDefault": true
       }
     }
   ]
-}
+}

apps/fabric-website/.vscode/settings.json

@@ -1,3 +1,3 @@
 {
   "typescript.tsdk": "./node_modules/typescript/lib"
-}
+}

apps/fabric-website/CHANGELOG.json

@@ -105,7 +105,8 @@
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
             "commit": "d3a85ba759d58bd74e4a1741ab73b729c96fa637",
-            "comment": "When navigating to a new page, the page will now be scrolled to the top instead of whatever position of the page you were on."
+            "comment":
+              "When navigating to a new page, the page will now be scrolled to the top instead of whatever position of the page you were on."
           }
         ]
       }
@@ -361,7 +362,8 @@
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
             "commit": "8370f6f5c822189fbd84e13fb285df83b102a308",
-            "comment": "Improved left nav scroll behavior and added fix to webpack so that we can load component pages from our local machines with the UHF."
+            "comment":
+              "Improved left nav scroll behavior and added fix to webpack so that we can load component pages from our local machines with the UHF."
           }
         ],
         "dependency": [
@@ -399,7 +401,8 @@
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
             "commit": "a9d0f70495f315998a5dad78699ffd2349436420",
-            "comment": "Adding left nav scroll functionality, including fixing the left nav with the header. Other layout refactoring to accommodate."
+            "comment":
+              "Adding left nav scroll functionality, including fixing the left nav with the header. Other layout refactoring to accommodate."
           }
         ],
         "dependency": [
@@ -444,7 +447,8 @@
           {
             "author": "David Zearing <dzearing@microsoft.com>",
             "commit": "08e59c871894c8ff443d48dbe5b0dd3316eb4331",
-            "comment": "Updated build to newest React version and typings. Updated tests and made various tweaks to the code to remove React warnings and keep Enzyme"
+            "comment":
+              "Updated build to newest React version and typings. Updated tests and made various tweaks to the code to remove React warnings and keep Enzyme"
           }
         ],
         "dependency": [
@@ -520,7 +524,8 @@
           {
             "author": "Eddie Liu <leddie24@gmail.com>",
             "commit": "67466325ed0ff6b89f82fa152860f968d8d740a0",
-            "comment": "Add ActivityItem, Calendar, HoverCard, OverflowSet, ScrollablePane, TeachingBubble to fabric-website"
+            "comment":
+              "Add ActivityItem, Calendar, HoverCard, OverflowSet, ScrollablePane, TeachingBubble to fabric-website"
           }
         ],
         "dependency": [
@@ -687,7 +692,8 @@
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
             "commit": "9a399cc9187ec81611acec92655e3393878e28e1",
-            "comment": "Added/removed Best Practices links for component pages that had/didn't have a Best Practices section."
+            "comment":
+              "Added/removed Best Practices links for component pages that had/didn't have a Best Practices section."
           },
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
@@ -711,7 +717,8 @@
           {
             "author": "Jon Schectman <joschect@microsoft.com>",
             "commit": "8e1dcc66cda8334653a8b5ccbde02bf6275e0b23",
-            "comment": "TSConfig: update to use preserveConstEnums so that certain builds s ystems don't break when importing const enums"
+            "comment":
+              "TSConfig: update to use preserveConstEnums so that certain builds s ystems don't break when importing const enums"
           }
         ],
         "dependency": [
@@ -871,7 +878,8 @@
           {
             "author": "John Miller <rubixws@gmail.com>",
             "commit": "40e1ef1d6ac5ee498888e7200fd15af754d7b665",
-            "comment": "Switched some font colors on theme and neutral color swatches from white to black to achieve minimum contrast requirement of 4.5:1 for accessibility."
+            "comment":
+              "Switched some font colors on theme and neutral color swatches from white to black to achieve minimum contrast requirement of 4.5:1 for accessibility."
           },
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
@@ -886,7 +894,8 @@
           {
             "author": "John Miller <rubixws@gmail.com>",
             "commit": "40e1ef1d6ac5ee498888e7200fd15af754d7b665",
-            "comment": "Changed where Fabric Core and Fabric React versions were drawing from so that they would appear as a number instead of a range."
+            "comment":
+              "Changed where Fabric Core and Fabric React versions were drawing from so that they would appear as a number instead of a range."
           },
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
@@ -896,7 +905,8 @@
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
             "commit": "faef37358c373a6848b8eab6ef4e3df05b5e9697",
-            "comment": "Added section in ResourcePage for XD Toolkits and other assets, includes references on other pages, too."
+            "comment":
+              "Added section in ResourcePage for XD Toolkits and other assets, includes references on other pages, too."
           }
         ],
         "dependency": [
@@ -951,7 +961,8 @@
           {
             "author": "John Miller <rubixws@gmail.com>",
             "commit": "055dd03c8ad9d74843f2bc3445d529a3c1fd8cb5",
-            "comment": "Major site revisions, component updates, removal of dev office header and footer, infrastructure updates and improvements, webpack config updates."
+            "comment":
+              "Major site revisions, component updates, removal of dev office header and footer, infrastructure updates and improvements, webpack config updates."
           }
         ],
         "dependency": [
@@ -1046,7 +1057,8 @@
           {
             "author": "lynamemi <lynam.emily@gmail.com>",
             "commit": "2d179149380245f586834535299b5832094bee6d",
-            "comment": "Updated the CDN link on the \"Get Started\" page and section to an updated version of Fabric Core, 7.2.0"
+            "comment":
+              "Updated the CDN link on the \"Get Started\" page and section to an updated version of Fabric Core, 7.2.0"
           }
         ],
         "dependency": [
@@ -1106,7 +1118,8 @@
           {
             "author": "John Miller <rubixws@gmail.com>",
             "commit": "16591f25f5ee2502e13e2ba1d764b4198e04d8ee",
-            "comment": "Updated fabric build system to use webpack dev server, removed the explicit !json loader in require statements."
+            "comment":
+              "Updated fabric build system to use webpack dev server, removed the explicit !json loader in require statements."
           }
         ],
         "dependency": [
@@ -1528,4 +1541,4 @@
       }
     }
   ]
-}
+}

apps/fabric-website/config/pre-copy.json

@@ -1,7 +1,5 @@
 {
   "copyTo": {
-    "lib": [
-      "./src/**/*.json"
-    ]
+    "lib": ["./src/**/*.json"]
   }
-}
+}

apps/fabric-website/package.json

@@ -13,6 +13,7 @@
   "scripts": {
     "build": "node ../../scripts/build.js",
     "clean": "node ../../scripts/clean.js",
+    "code-style": "node ../../scripts/code-style.js",
     "start": "node ../../scripts/start.js",
     "production": "node --max_old_space_size=8192 ../../scripts/build.js --production",
     "dogfood": "node --max_old_space_size=8192 ../../scripts/build.js --dogfood",
@@ -44,4 +45,4 @@
     "office-ui-fabric-react": ">=6.4.0 <7.0.0",
     "tslib": "^1.7.1"
   }
-}
+}