Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BabelFishSubscription: Subscription options not fully passed #6

Open
aaron-jca opened this issue Mar 18, 2024 · 2 comments
Open

BabelFishSubscription: Subscription options not fully passed #6

aaron-jca opened this issue Mar 18, 2024 · 2 comments

Comments

@aaron-jca
Copy link

Noticed that when constructing a BabelFishSubscription the option is passed, and the events are used.
Here a new options is constructed
and the option events are used

This unfortunately disallows the use of QoS overrides, and likely other things from the original options.
Here's an article where QoS overrides are discussed.

@aaron-jca
Copy link
Author

I also tried this with publishers and was unable to get them working. Could also be bugged there, but its also possible I had some syntax wrong... I was a bit rushed

@StefanFabian
Copy link
Member

Sorry for the late reply.
Not sure if I understand the issue correctly, I have changed this code slightly for jazzy and am doing basically the same as the normal templated Subscription.
Does that fix the issue?
I am open for PRs that address this issue for earlier versions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants