-
-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve audio quality implementation #7243
Draft
sakertooth
wants to merge
33
commits into
LMMS:master
Choose a base branch
from
sakertooth:fix-resample-quality
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to try and remove libsamplerate from this as well and use the functions within |
This is so that we do not expose all of the possible converter types (some of which shouldn't be used at all, like ZOH)
Will default to always use 4-point hermite for now.
sakertooth
force-pushed
the
fix-resample-quality
branch
from
May 27, 2024 07:42
b5e72dd
to
e711ea3
Compare
sakertooth
changed the title
Revamp interpolation quality for resampling
Improve audio quality implementation
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resampling audio, it was common for us to:
SRC_LINEAR
converter type onlySRC_STATE
to resample.This PR addresses these concerns by:
SRC_STATE
's to use theAudioResampler
libsamplerate wrapperAudioResampler
This also addresses the issue where pitch bending would cause major aliasing and audible "crackles" since linear interpolation was being used. The user can now choose an appropriate interpolation mode to avoid this from happening.
The functions in
interpolation.h
could've been used for this, but it was simpler to continue using libsamplerate for the time being, though it may be worth exploring the use of these functions instead of libsamplerate in the future. The code that currently uses these for resampling were left alone (e.g.,VibratingString::resample
was untouched).