InstrumentSoundShaping refactoring #7229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add private accessors for the volume, cutoff and resonance parameters (envelope and LFO). This makes the code less technical and more readable as it for example removes lots of static casts. The casts are now done in a special helper method that returns the parameters for a given target.
Remove the `EnvelopeAndLfoParameters` array and use explicit instances for volume, cutoff, resonance. This simplifies construction and initialization of the instances. Besides the array this also removes the `Target` enum and the `NumTargets` value. To simplify storage and retrieval of the parameters three private methods have been added which provide the node names of the volume, cutoff and resonance parameters. Adjust `InstrumentSoundShapingView` to the removed `NumTargets` property.
Use references to the volume, cutoff and resonance parameters instead of pointers.
Remove the friend relationship between `InstrumentSoundShaping` and its related view by providing the models via getters.
Get rid of `InstrumentSoundShaping::targetNames` by using translations and strings directly. Move the remaining stuff into `InstrumentSoundShapingView` until it is removed there as well.
Remove the array of EnvelopeAndLfoViews and use dedicated instances instead. This also enables the final removal of the remaining `targetNames`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessors for volume, cutoff, resonance
Add accessors for the volume, cutoff and resonance parameters (envelope and LFO). Use references instead of pointers.
This makes the code less technical and more readable as it for example removes lots of static casts. The casts are now done in a special helper method that returns the parameters for a given target.
Remove EnvelopeAndLfoParameters array
Remove the
EnvelopeAndLfoParametersarray and use explicit instances for volume, cutoff, resonance. This simplifies construction and initialization of the instances.Besides the array this also removes the
Targetenum and theNumTargetsvalue.To simplify storage and retrieval of the parameters three private methods have been added which provide the node names of the volume, cutoff and resonance parameters.
Adjust
InstrumentSoundShapingViewto the removedNumTargetsproperty.Remove friend relationship
Remove the friend relationship between
InstrumentSoundShapingandInstrumentSoundShapingViewby providing the models via getters.Fix memory leak
This pull request also removes a memory leak because the
InstrumentSoundShapinghas no explicit destructor and it therefore has never deleted theEnvelopeAndLfoParametersinstances that it instantiated in its constructor.