Format DrumSynth

[Monospace-V]

This file is so old I am making a separate pull request for it instead of grouping its cleaning with the rest of my categories.
Several issues here.
Bad formatting includes poor space usage (no space around operators / flow control), bad nextline usage and bad indentation (two space indentation instead of tab).

Additionally there is ugly logic (nested if loops).

I will fix as much of the formatting as I can myself. I cannot speak for the rest.
Hopefully the next person approaching this file will have at least a better formatted task ahead of them.

[Monospace-V]

someone will want to run through this and check space usage where typecasting is done, and maybe glance through conventions?

[Rossmaxx]

Some initial thoughts i got from the diff. Try solving these. I haven't included all of it.

[sakertooth]

You know, it would've taken zero effort to format the entire document if you wanted to satisfy our formatting conventions.

[Monospace-V]

You know, it would've taken zero effort to format the entire document if you wanted to satisfy our formatting conventions.

Unfortunately, I am stupid.

[Monospace-V]

You know, it would've taken zero effort to format the entire document if you wanted to satisfy our formatting conventions.

It is too late now. I have put in non-zero effort which cannot be backspaced. I shall continue to do so. But would be kinda useful if you could tell me more about this

[sakertooth]

It is too late now. I have put in non-zero effort which cannot be backspaced. I shall continue to do so. But would be kinda useful if you could tell me more about this

There are probably other ways, but using VSCode with our .clang-tidy (.clang-format) file allows you to format the entire document based on what is specified there. I can push a commit to format everything here for you if you want.

[Monospace-V]

There are probably other ways, but using VSCode with our .clang-tidy file allows you to format the entire document based on what is specified there. I can push a commit to format everything here for you if you want.

Ah. The weird stuff I don't understand. I keep forgetting it exists
Dunno enough. If you think that would be a sensible idea, sure go right ahead
At this point, if it does that, why don't we do everything with that instead?

[sakertooth]

At this point, if it does that, why don't we do everything with that instead?

Usually, we don't do this because there are a lot of out of scope changes it create when making PRs. But since this is a formatting PR, all the changes in here would be relevant and in scope.

[Monospace-V]

Usually, we don't do this because there are a lot of out of scope changes it create when making PRs. But since this is a formatting PR, all the changes in here would be relevant and in scope.

Wait. All those PRs I plan to do to clean and there's a command I could do that just wasn't being done?
Can you (on discord maybe) just help me understand how it's done. Is it an option to go through and format a lot of files with this so everything's up to format?

[Monospace-V]

I notice that some of the block brace work has been deleted, among other things. Your commit would mostly format whitespaces and ordering.


@sakertooth should I redo some of that work on this directly, or would you run that command on my last commit with that stuff done?
In the future I'll probably want to run that first and then go on with looking through.

[sakertooth]

Let me know if there's anything else that should be done here 👍.

[Monospace-V]

It looks about right at first glance. I will check it from PC at a later point. Thank you.
Can you at some point explain to me what you did and direct me to the applicable documentation for the same?

[sakertooth]

Can you at some point explain to me what you did and direct me to the applicable documentation for the same?

Our .clang-tidy and .clang-format files pretty much make up what was done here (though the transition to use the named casts instead of C-style casts was done manually). You can take a look there for some ideas. Here are some details on clang-tidy and clang-format.

[Monospace-V]

I notice you have moved the asterisks. I was under the impression that char *key and char* key meant different things, but I believe you know what you are doing. I just want to bring this to your attention to confirm.

Additionally I perceive some confusing nextline usage/requirement I will probably want to resolve. I will not be at my home computer for about two or three days, so unlikely to do it till then. I will try to see if I can do something about it anyway.

I am under the understanding this pull request still be marked as ready for review due to your tendency to keep it that way.

[Veratil]

I was under the impression that char *key and char* key meant different things

They actually are the same in this context. This confusion is why we put the pointer with the type instead of with the variable name.

[sakertooth]

Additionally I perceive some confusing nextline usage/requirement I will probably want to resolve. I will not be at my home computer for about two or three days, so unlikely to do it till then. I will try to see if I can do something about it anyway.

Feel free to do anything remaining that you think fits with our conventions, I just wanted to help you out a bit since it seemed like you were facing some difficulty with this file. 👍