Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean src/core/ A* #7163

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Clean src/core/ A* #7163

wants to merge 12 commits into from

Conversation

Monospace-V
Copy link
Contributor

@Monospace-V Monospace-V commented Mar 26, 2024 •
edited

Update to coding conventions.
Some cases I might be unsure. Requesting review.
This PR will have the src/core/ files starting with A.
Doing a set at a time.

Covers:
src/core/* :
AudioEngine.cpp
AudioEngineProfiler.cpp
AudioEngineWorkerThread.cpp
AudioResampler.cpp
AutomatableModel.cpp
AutomationClip.cpp
AutomationNode.cpp

sakertooth
sakertooth reviewed Mar 27, 2024
View reviewed changes
src/core/AudioEngine.cpp Outdated
m_audioDevName = AudioDummy::name();
m_midiClient = new MidiDummy;
m_midiClientName = MidiDummy::name();
} else {
} else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else
}
else

src/core/AudioEngine.cpp Outdated
{
MidiWinMM * mwmm = new MidiWinMM;
// if( moss->isRunning() )
// if ( moss->isRunning() )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, but since you've already started formatting it:

Suggested change
// if ( moss->isRunning() )
// if (moss->isRunning())

src/core/AudioEngine.cpp Outdated Show resolved Hide resolved
@sakertooth
Copy link
Contributor

Putting this as ready for review since you mentioned you were requesting review.

@sakertooth sakertooth marked this pull request as ready for review March 27, 2024 13:21
@Monospace-V @sakertooth
Update src/core/AudioEngine.cpp
6cd960f 
Oh. big important

Co-authored-by: saker <sakertooth@gmail.com>
@Monospace-V Monospace-V marked this pull request as draft March 28, 2024 13:44
@sakertooth
Copy link
Contributor

Removed the printf suggestions, I'm not actually sure if they should be removed as of right now.

@Monospace-V
Copy link
Contributor Author

Putting this as ready for review since you mentioned you were requesting review.

Thank you. There are still a few things I want to get through, and I have a very clogged schedule presently, but I will get to this as soon as I can. I forgot "ready for review" meant a label of a PR ready for review, and my request for reviewing was to make sure I didn't accidentally eat a bracket or something(as you have noticed and pointed out, thank you!), and I need to get through this once more, and implement the rest of your suggestions along with anything else that is appropriate.

@Monospace-V Monospace-V marked this pull request as ready for review March 31, 2024 04:10
@Monospace-V
Copy link
Contributor Author

Now it is ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakertooth sakertooth sakertooth left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Monospace-V @sakertooth