Redesign file browser searching #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irrenhaus3
reviewed
May 9, 2024
Veratil
reviewed
May 10, 2024
The search will get destroyed when replacing it with the new one through the assignment
…ers or not So the search was broken and missing entries because the code was not searching through the directories that *did* match the filters. This is also why the search was oddly fast and completed very quickly.
|
I did some quick UI testing in a Linux VM. This is quite fabolous. search_bar_min2.mov |
tresf
approved these changes
May 17, 2024
|
I looked over the bits I wanted to check (specifically the thread pool) and I think it's fine for now. The only thing I would add is to make sure that text files have a trailing line feed. GitHub marks those that don't in the diff with a no-entry symbol at the end of the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigns the file browser searching functionality. In particular, the design was now made to be more extensible to allow other tasks we may want to run asynchronously in the future by introducing a
ThreadPoolclass. All the file search related logic is now encapsulated as its own function object namedFileSearchthat can be used together with aThreadPool.