Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply code style to hiopHessianLowRank #642

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

apply code style to hiopHessianLowRank #642

wants to merge 2 commits into from

Conversation

nychiang
Copy link
Collaborator

@nychiang nychiang commented Jun 30, 2023 •
edited

Re-edit hiopHessianLowRank.hpp and hiopHessianLowRank.cpp', according to the latest code style guidelines in README_developers.md`

CLOSE #641

@nychiang nychiang requested a review from cnpetra June 30, 2023 06:36
@nychiang nychiang force-pushed the codestyle-hessianlowrank-fix branch from eb50e56 to 1cff5a6 Compare June 30, 2023 06:41
@nychiang
Copy link
Collaborator Author

@cnpetra Further clean up can be applied to hiopHessianLowRank.cpp. For example, some code have never been used, see ex1 and ex2
You may want to have a look of them, and decide if we should keep them or not.

@nychiang nychiang force-pushed the codestyle-hessianlowrank-fix branch from 1cff5a6 to 2e62c25 Compare June 30, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnpetra cnpetra Awaiting requested review from cnpetra

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update code style in hiopHessianLowRank
1 participant
@nychiang