-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Concepts refactor #8
base: main
Are you sure you want to change the base?
Commits on Nov 19, 2019
-
concepts: refactor convertible_to out to is_convertible
This is the beginning of a relatively large concepts/type-traits refactor that is going to come in over the next while. First is factoring out convertible_to so it looks/works more like the standard library version so I can start converting detector into a more user-friendly version we can actually expose. This is a bug for GEOSX and others, and should also make our type_traits more robust once it's all in.
Configuration menu - View commit details
-
Copy full SHA for ec836c2 - Browse repository at this point
Copy the full SHA ec836c2View commit details -
concepts: refactor detection out into detect.hpp
With the is_convertible changes, this is the basis for the whole refactor setup. Concepts will all be defined against the new detector, as will type traits, using the new idiom through the macro so if we need to do this again it wont have to touch them all.
Configuration menu - View commit details
-
Copy full SHA for d2b86c7 - Browse repository at this point
Copy the full SHA d2b86c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 124fe8c - Browse repository at this point
Copy the full SHA 124fe8cView commit details -
incorporate full detector tests
tests integrated, and some concepts ported, more to go
Configuration menu - View commit details
-
Copy full SHA for f70a876 - Browse repository at this point
Copy the full SHA f70a876View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1556f42 - Browse repository at this point
Copy the full SHA 1556f42View commit details -
major concept refactor, they all work now
concepts are working again, and actually have tests in detect.cpp, there are new macros for defining detectors, requirements (helper for detectors), concepts, and all-in-one doing a concept and associated traits. It's possible there are breaking changes in here if anyone external is relying on the concepts, but since many of them were broken I'm hoping this will be a net benefit.
Configuration menu - View commit details
-
Copy full SHA for fbf97a0 - Browse repository at this point
Copy the full SHA fbf97a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0d0041 - Browse repository at this point
Copy the full SHA e0d0041View commit details -
Configuration menu - View commit details
-
Copy full SHA for d781ad0 - Browse repository at this point
Copy the full SHA d781ad0View commit details -
Remove unnecessary stl headers, factor out their usage, also use builtins for typelist lookups when available.
Configuration menu - View commit details
-
Copy full SHA for e12f75c - Browse repository at this point
Copy the full SHA e12f75cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e12f749 - Browse repository at this point
Copy the full SHA e12f749View commit details -
optimize all_of, tuple instantiation 4x faster
In C++17 mode use built-in fold expressions, in 14 use a simpler type. When in 14 mode this buys up to 30% improvement, in 17 mode it's almost four *times* faster to instantiate tuples now. Should help with RAJA compile times where 17 is available.
Configuration menu - View commit details
-
Copy full SHA for dc91e46 - Browse repository at this point
Copy the full SHA dc91e46View commit details -
more tuple compilation time enhancement
Turn tuple_storage into an aggregate when possible, turns out this is not possible on nvcc right now, but elsewhere it's a nice little 5-20% bump.
Configuration menu - View commit details
-
Copy full SHA for 51e66d9 - Browse repository at this point
Copy the full SHA 51e66d9View commit details
Commits on Nov 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 28597de - Browse repository at this point
Copy the full SHA 28597deView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6892c - Browse repository at this point
Copy the full SHA ed6892cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb60365 - Browse repository at this point
Copy the full SHA cb60365View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6b35e2 - Browse repository at this point
Copy the full SHA c6b35e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad30597 - Browse repository at this point
Copy the full SHA ad30597View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b0edd1 - Browse repository at this point
Copy the full SHA 3b0edd1View commit details
Commits on Nov 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f5e29cf - Browse repository at this point
Copy the full SHA f5e29cfView commit details