WIP: Feature/probinso/hipcc support #596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…print_target_properties_recursive
Co-authored-by: Chris White <white238@llnl.gov>
… github.com:LLNL/blt into feature/chapman39/print_target_properties_recursive
…com:LLNL/blt into feature/chapman39/replace_corona_with_tioga
robinson96
changed the title
adayton1
reviewed
Sep 29, 2022
| @@ -187,7 +187,9 @@ if (NOT BLT_LOADED) | |||
| # File extension lists used to filter sources based on languages for code checks | |||
| # and filtering Fortran sources out of cuda/hip source lists | |||
| # Note: this filtering is case-insensitive | |||
| set(BLT_C_FILE_EXTS ".cpp" ".hpp" ".cxx" ".hxx" ".c" ".h" ".cc" ".hh" ".inl" ".cu" ".cuh" | |||
| set(BLT_C_FILE_EXTS ".c" ".h" | |||
| CACHE STRING "List of known file extensions used for C/CXX sources") | |||
There was a problem hiding this comment.
Update the comment to say C rather than C/CXX. And the following comment should have CXX instead of C/CXX.
There was a problem hiding this comment.
This will have pretty large user facing consequences and needs to be considered carefully.
There was a problem hiding this comment.
Might only be my problem though:
adayton1
reviewed
Sep 29, 2022
| if(${_hip_runtime_index} GREATER -1) | ||
| set(_depends_on_hip_runtime TRUE) | ||
| endif() | ||
| message("DEPENDS ON HIP ${_depends_on_hip} DEPENDS_ON_HIP_RUNTIME ${_depends_on_hip_runtime}\n\t ${arg_DEPENDS_ON}") |
There was a problem hiding this comment.
Is this a debug message? There are a few others like it as well.
adayton1
reviewed
Sep 29, 2022
| set_source_files_properties( ${_hip_sources} PROPERTIES | ||
| LANGUAGE HIP) | ||
|
|
||
| # if (HIP_SEPARABLE_COMPILATION) |
There was a problem hiding this comment.
Can you document why this isn't being used?
… github.com:LLNL/blt into feature/chapman39/print_target_properties_recursive
…erties_recursive Print target properties recursively and with regular expressions
add macro to assist in checking if code snippets compile
Add BLT_CMAKE_IMPLICIT_LINK_LIBRARIES_EXCLUDE variable
V0.5.2 Release Candidate
v0.5.2 mergeback
Fixes `crayftn` + hip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for using CMAKE_HIP_COMPILER in cmake versions 3.21 and greater.
Differentiate between C_LIST and CXX_LIST for blt_split_source_list_by_language. (HIPCC will error if it's a c file, while cuda will just treat it as a C++ file).
SetupHIP now enables the hip language.
Add option BLT_HIP_REMOVE_HIP_COMPILE_OPTIONS to remove flags associated with pre-installed hip::device and hip-lang::device targets that are incompatible with hipcc.