WIP: Revamp CUDA support #585
Conversation
cmake/BLTOptions.cmake
Outdated
| option(BLT_CUDA_LINK_WITH_NVCC "Enable linking with NVCC" OFF) | ||
| if (DEFINED CUDA_LINK_WITH_NVCC) | ||
| message(WARNING "CUDA_LINK_WITH_NVCC is deprecated and will eventually be removed.") | ||
| set(BLT_CUDA_LINK_WITH_NVCC ${CUDA_LINK_WITH_NVCC}) |
There was a problem hiding this comment.
Does this need to be CACHE FORCE?
There was a problem hiding this comment.
I was thinking that too as I did it =) I'll test it out
There was a problem hiding this comment.
I reworked it to just populate the option()..
|
@white238 will this require a syntax change for BLT users like the recent change in HIP support; e.g., 'cuda_runtime' --> 'cuda::runtime'? |
Yes this is a breaking change in the following ways:
|
white238
force-pushed
the
feature/white238/cuda_revamp
branch
from
2ef7009
to
b178da6
Compare
|
We should probably add this to the https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html#cuda-driver-library |
This removes the old deprecated FindCUDA and mimic's what @davidbeckingsale did for HIP support.
Breaking changes:
cuda->blt::cudacuda_runtime->blt::cuda_runtimeCMAKE_LINK_WITH_NVCC->BLT_CMAKE_LINK_WITH_NVCC(warning about former being deprecated)Thanks to @kennyweiss for sitting on a webex while I drastically rip support out from under myself!