change COMPILER_FAMILY_IS flags to CACHE variables so users can have … #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…control over detected famkily type.
|
I am curious what caused this to not work? |
white238
previously approved these changes
Aug 14, 2021
|
I am concerned these variables would be pushed from directory scoped to global and are not prefixed with "BLT_". Do codes ever use these variables? Can we just prefix them now so they dont potentially conflict with project variables? Thoughts @kennyweiss ? Edit: RAJA does use these variables... |
|
I agree with @white238's concern -- it seems that if we're exposing these to the cache, we should prefix them with I am also interested in hearing about what prompted this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…control over detected family type.