Bugfix/gunney/marching cubes large mesh #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build failure. emplace_back causes a warning about calling a host function from a device function. I don't see how it can happen, but it may be critical to the app's build.
Facet increments will never have values higher than 16, so uint16_t should be fine, but when we scan it and store in the wider IndexType, the addition seems to be done as uint16_t, which unexpectedly rolls over.
gunney1
requested review from
BradWhitlock,
rhornung67,
agcapps,
bmhan12,
kennyweiss and
publixsubfan
|
Related to LLNL/RAJA#1631 |
agcapps
approved these changes
Apr 22, 2024
white238
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bigger integer type for number of facets per parent cell
It changes the type of the number-of-facets-per-parent-cell from
uint16_ttoIndexType.The 16-bit type was problematic because, the sum scan on it apparently uses 16-bit adds instead of promoting the items to the output
IndexType. The array doesn't need to be bigger than 16-bit, because it only has to store values in [0,5]. But this change is necessary to prevent the sum from rolling over at 2^16. On rzgenie and rzansel, the data did get promoted to 32-bit before adding, so the bug didn't affect them. RAJA issue LLNL/RAJA#1631 should address this inconsistency.