Add comment of unified id usage where preferred instead of mandatory

LLNL · Apr 10, 2024 · 7336064 · 7336064
1 parent b610f8f
commit 7336064
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/axom/core/tests/core_array_for_all.hpp b/src/axom/core/tests/core_array_for_all.hpp
@@ -1205,7 +1205,8 @@ AXOM_TYPED_TEST(core_array_for_all, device_insert)
 
   int kernelAllocID = axom::execution_space<ExecSpace>::allocatorID();
 #if defined(AXOM_USE_GPU) && defined(AXOM_USE_UMPIRE)
-  // Use unified memory
+  // Use unified memory for frequent movement between device operations
+  // and value checking on host
   if(axom::execution_space<ExecSpace>::onDevice())
   {
     kernelAllocID = axom::getUmpireResourceAllocatorID(

diff --git a/src/axom/quest/tests/quest_discretize.cpp b/src/axom/quest/tests/quest_discretize.cpp
@@ -197,7 +197,8 @@ void run_degen_segment_tests()
 
   int allocID = axom::execution_space<axom::SEQ_EXEC>::allocatorID();
 
-  //Use unified memory on device
+  // Use unified memory for frequent movement between device operations
+  // and value checking on host
 #if defined(AXOM_USE_GPU) && defined(AXOM_USE_UMPIRE)
   if(axom::execution_space<ExecPolicy>::onDevice())
   {
@@ -291,7 +292,8 @@ void run_single_segment_tests()
 {
   int allocID = axom::execution_space<axom::SEQ_EXEC>::allocatorID();
 
-  //Use unified memory on device
+  // Use unified memory for frequent movement between device operations
+  // and value checking on host
 #if defined(AXOM_USE_GPU) && defined(AXOM_USE_UMPIRE)
   if(axom::execution_space<ExecPolicy>::onDevice())
   {
@@ -397,7 +399,8 @@ void run_multi_segment_tests()
 {
   int allocID = axom::execution_space<axom::SEQ_EXEC>::allocatorID();
 
-  //Use unified memory on device
+  //Use unified memory for frequent movement between device operations
+  // and value checking on host
 #if defined(AXOM_USE_GPU) && defined(AXOM_USE_UMPIRE)
   if(axom::execution_space<ExecPolicy>::onDevice())
   {