Add Synchronizer strategy #821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
previously approved these changes
May 3, 2023
mcfadden8
requested changes
May 8, 2023
There was a problem hiding this comment.
For testing, I think it would be good to have a test (that could also serve as an example) that simply creates an allocator of this kind and uses it for a couple of allocations and deallocations. This would be a minimum test to make sure that everything links up and the calls all successfully pass through without error.
davidbeckingsale
changed the title
…o feature/sync-before-free
MrBurmark
reviewed
Jun 1, 2023
| namespace resources { | ||
| inline namespace v1 { | ||
|
|
||
| inline std::string to_string(camp::resources::Resource& r) |
There was a problem hiding this comment.
We should fix the constness of get_platform in camp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.