Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enhancements to Operators and Reduction Scaffolding #868

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

willkill07
Copy link
Member

Summary

  • This PR is an enhancement with some bug fixes and new features

It does the following:

  • Introduce BitXor reduction
  • operators::largest didn't have the correct overload for integral GPU types
  • op_adapter template simplified
  • static_assert checks introduced for:
    • integral types for bitwise operations
    • associative operators for reductions

To Do

  • testing
  • continue to evaluate current operator and reduction mechanisms

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #868 into develop will decrease coverage by 0.041%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop      #868       +/-   ##
=============================================
- Coverage   96.829%   96.788%   -0.042%     
=============================================
  Files           99        99               
  Lines         2555      2553        -2     
=============================================
- Hits          2474      2471        -3     
- Misses          81        82        +1     
Impacted Files Coverage Δ
include/RAJA/pattern/detail/reduce.hpp 100.000% <100.000%> (ø)
include/RAJA/util/Operators.hpp 100.000% <100.000%> (ø)
include/RAJA/policy/atomic_builtin.hpp 98.076% <0.000%> (-1.924%) ⬇️
include/RAJA/util/sort.hpp 95.402% <0.000%> (-0.053%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81a530...a13f963. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant