Fix hip scan accumulation types #1634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
force-pushed
the
feature/burmark1/hip_scan
branch
from
6ba0ffa
to
f920936
Compare
rhornung67
reviewed
Apr 29, 2024
| InputIter, | ||
| OutputIter, | ||
| Function, | ||
| AccType>(d_temp_storage, |
There was a problem hiding this comment.
I think the compilation failure is because the ROCm template you are calling here only has 4 template params and you have five. Specifically, AccType does not appear in the ROCm implementation.
There was a problem hiding this comment.
Ya, I just realized that.
It looks like all the released versions of rocprim don't have the 5th AccType template argument as of rocm 6.1.0. Though this template argument does exist on rocprim develop.
There was a problem hiding this comment.
It's also not in rocm 5.7.x, which is what we are currently testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent scan accumulation types in hip backend compared to other backends
TODO: