Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Fixing #3481

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

README Fixing #3481

wants to merge 8 commits into from

Conversation

EditaNEmilis
Copy link

@EditaNEmilis EditaNEmilis commented Jun 15, 2023

Tiny or small fix with the typo and others.
But only two files (or more), can be minor changes tho..

Can be a tiny or small fix with the typo and other what.. Just saying.
Copy link

@X64X2 X64X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not detailed well enough

@EditaNEmilis
Copy link
Author

Gerai then..

Typo spotted and other.
But still an minor fix with those files.
Grammar and other changes.. Maybe.
Okay, maybe that's a big one commit from these 14 files.. Grammar and other.
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@@ -10,16 +10,16 @@ Languages English

Dataset Structure This dataset follows the OA format, which is:

INSTRUCTION (string): The user asks for a poem (from a variety of premade
- NSTRUCTION (string): The user asks for a poem (from a variety of premade
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be INSTRUCTION

@@ -14,7 +14,7 @@ dialogue using a preset list of user prompt templates.
### Some ideas for extending this dataset

This dataset is nicely structured, and the ingredients section includes the
quantities and units separated out. Some, but not all already include a
quantities and units separated out. Somehow, but not all already include a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct - "Some" is right

Minor repair with both files.
@EditaNEmilis
Copy link
Author

Commited and fixed.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@andreaskoepf
Copy link
Collaborator

@EditaNEmilis could you please fix pre-commit & the solve the conflict? thx

@EditaNEmilis
Copy link
Author

I'm trying to.. But it's not working.

@andrewm4894
Copy link
Collaborator

andrewm4894 commented Jul 21, 2023

https://github.com/LAION-AI/Open-Assistant/actions/runs/5326388567/job/14415197147?pr=3481

data/datasets/poetry_instruction/README.md

it either likes or does not like the spaces here:

 - INSTRUCTION (string): The user asks for a poem (from a variety of premade
-prompts) with topics (tags). If the given poem has no tags, the user asks for a
-poem on it's own.
+  prompts) with topics (tags). If the given poem has no tags, the user asks for
+  a poem on it's own.
 
-- RESPONSE (string): The assistant replies with the poem and title (from a variety
-of premade prompts).
+- RESPONSE (string): The assistant replies with the poem and title (from a
+  variety of premade prompts).
 
 - SOURCE (string): The source is PoetryFoundation.org and the poet's name.
 
 - METADATA (JSON String): {"author": "author of the original poem", "title":
-"title of the poem", "tags": "tags from poetry foundation."}
+  "title of the poem", "tags": "tags from poetry foundation."}

so i think if you remove those spaces at start of line it might fix it

If gets too messy then i'd just undo your changes in this file and make it so its same as whats currently in master. That would also be one solution.

@andrewm4894
Copy link
Collaborator

i fixed the conflict

@andrewm4894
Copy link
Collaborator

ill try fix pre-commit on this end

@EditaNEmilis
Copy link
Author

Alright. Thanks.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@andrewm4894
Copy link
Collaborator

andrewm4894 commented Jul 21, 2023

(not able to fix on my end since is in a fork)

@EditaNEmilis can you run pre-commit run --all?

and then commit the changes it makes

Did a full (or all files) pre-commit run. I guess..
@andrewm4894 andrewm4894 enabled auto-merge (squash) July 21, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants