New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README Fixing #3481
base: main
Are you sure you want to change the base?
README Fixing #3481
Conversation
Can be a tiny or small fix with the typo and other what.. Just saying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not detailed well enough
Gerai then.. |
Typo spotted and other. But still an minor fix with those files.
Grammar and other changes.. Maybe.
Okay, maybe that's a big one commit from these 14 files.. Grammar and other.
❌ pre-commit failed. |
@@ -10,16 +10,16 @@ Languages English | |||
|
|||
Dataset Structure This dataset follows the OA format, which is: | |||
|
|||
INSTRUCTION (string): The user asks for a poem (from a variety of premade | |||
- NSTRUCTION (string): The user asks for a poem (from a variety of premade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be INSTRUCTION
data/datasets/recipes/README.md
Outdated
@@ -14,7 +14,7 @@ dialogue using a preset list of user prompt templates. | |||
### Some ideas for extending this dataset | |||
|
|||
This dataset is nicely structured, and the ingredients section includes the | |||
quantities and units separated out. Some, but not all already include a | |||
quantities and units separated out. Somehow, but not all already include a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct - "Some" is right
Minor repair with both files.
Commited and fixed. |
❌ pre-commit failed. |
@EditaNEmilis could you please fix pre-commit & the solve the conflict? thx |
I'm trying to.. But it's not working. |
https://github.com/LAION-AI/Open-Assistant/actions/runs/5326388567/job/14415197147?pr=3481 data/datasets/poetry_instruction/README.md it either likes or does not like the spaces here:
so i think if you remove those spaces at start of line it might fix it If gets too messy then i'd just undo your changes in this file and make it so its same as whats currently in master. That would also be one solution. |
i fixed the conflict |
ill try fix pre-commit on this end |
Alright. Thanks. |
❌ pre-commit failed. |
(not able to fix on my end since is in a fork) @EditaNEmilis can you run and then commit the changes it makes |
Did a full (or all files) pre-commit run. I guess..
Tiny or small fix with the typo and others.
But only two files (or more), can be minor changes tho..