Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent click on generate button if form is invalid #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strokyl
Copy link

@strokyl strokyl commented Apr 11, 2020

No description provided.

@NyKo24
Copy link

NyKo24 commented Apr 11, 2020

Que pense-tu de la proposition sur l'issue #79 ?

@strokyl
Copy link
Author

strokyl commented Apr 12, 2020

J'en pense cela: #50 (comment)

@mthgbr
Copy link

mthgbr commented Apr 15, 2020

+1

@Pign
Copy link

Pign commented Apr 15, 2020

Au lieu de refaire la validation il est possible d'utiliser les champs aria déjà définis.
Par ailleurs il vaut mieux utiliser aria-disabled="true" que disabled... En effet, avec disabled il n'y a pas de feedback audio pour un utilisateur aveugle (puisque le focus n'atteindra jamais "disabled")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants