New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display warning if JavaScript is disabled, fixes #15 #17
base: master
Are you sure you want to change the base?
Conversation
J'ai essayé d'utiliser bootstrap au maximum, tout en essayant d'intégrer au mieux le message dans la page déjà existant. |
<div id="noscript" class="d-flex align-items-center flex-column justify-content-center"> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div id="noscript" class="d-flex align-items-center flex-column justify-content-center"> | |
<p> | |
<p id="noscript" class="d-flex align-items-center flex-column justify-content-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je n'ai pas rebuild pour vérifier mais tu as bien checké que l'affichage reste toujours le même via ce changement (propriétés par défaut du div et du p qui ne sont pas les mêmes ?) ?
<a href="https://www.enable-javascript.com/fr/">Cliquez ici</a> pour accéder aux instructions | ||
pour activer JavaScript dans votre navigateur. | ||
</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</div> |
@@ -55,6 +55,17 @@ h2 { | |||
font-size: large; | |||
} | |||
|
|||
#noscript { | |||
margin: 250px 0 250px 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin: 250px 0 250px 0; | |
margin: 250rem 0 250rem 0; |
p { | ||
text-align: center; | ||
font-weight: bold; | ||
font-size: 1.3em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-size: 1.3em; | |
font-size: 1.3rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quel avantage les rem ont-ils par rapport aux em ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://caniuse.com/#feat=mdn-api_css_em
Le support des rem semble meilleur, non ?
document.addEventListener("DOMContentLoaded", function() { | ||
document.querySelector("#wrapper").classList.remove("d-none"); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cela me semble overkill d'ajouter du JS, j'aurai mis le texte en rouge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ca évite toute confusion au moins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu aurais mis quelle partie du texte en rouge ?
Je veux bien continuer d'éditer cette PR mais je ne pense pas qu'ils la mergent plus tard. |
This PR fixes #15, allowing users to get instructions on how to enable JavaScript for their browser in the case it is disabled.
This will enable more people to use the generator.