Remove unnecessary dependency on KoNLPy #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request Kyubyong#5 was enough for completely eliminating konlpy dependency.
|
안녕하세요, @Kyubyong 님! KoNLPy 가 GPL 3.0 라이센스여서 g2pK 가 Apache 2.0 라이센스를 따르더라도 KoNLPy 때문에 GPL 3.0 을 강제당할 우려가 있어 자세히 살펴보았는데, 현재 #5 에 따라 더 이상 g2pK 에 KoNLPy 에 의존하는 부분이 없는 것으로 보입니다. 이에 따라 관련하여 어떤 절차를 밟으면 좋을지 알려주시면 감사하겠습니다 :) |
|
안녕하세요, @Kyubyong 님! 혹시 이 풀 리퀘스트 반영 및 릴리즈 진행에 제가 도울 수 있는 방법이 있을까요? 알려주시면 최대한 진행해 보겠습니다..! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #5 was enough for completely eliminating konlpy dependency.
(I just found out that on PyPI the release version is 0.9.4 so this PR is assuming that next release would be 0.9.5.)