Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OneDrive shared folders. #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwmuller
Copy link

@dwmuller dwmuller commented Mar 4, 2021

Addresses issue #134.

This adds support for shared folders which a user has "added
to their OneDrive". Such folders appear as, effectively, symbolic
links in the user's default root folder. These changes do not
provide a way to access other OneDrive items that have been
shared with the user.

This adds support for shared folders which a user has "added
to their OneDrive". Such folders appear as, effectively, symbolic
links in the user's default root folder. These changes do not
provide a way to access other OneDrive items that have been
shared with the user.
@dwmuller
Copy link
Author

dwmuller commented Mar 4, 2021

I am open to considering a larger change that would make shared items generally accessible, but it would be a much larger set of changes that would impact (at least) URI format and item selection UI. It would require devising a way to change the URI format in a way that would be conflict-free with existing URIs. In essence, "Items Shared With me" is a set of items that are accessed through an entirely different mechanism, outside the user's default root folder.

In any case, this offering confined its changes to the OneDrive storage provider. I am happy to answer any questions you might have about it.

@Kyrodan
Copy link
Owner

Kyrodan commented Mar 8, 2021

Wow, thanks for this PR. I will review it an hopefully merge it to the codebase soon.

@Kyrodan Kyrodan added this to the 2.0.0 milestone Mar 8, 2021
@dwmuller
Copy link
Author

dwmuller commented Mar 8, 2021 via email

@Kyrodan Kyrodan modified the milestones: 2.0.0, 2.1.0 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants