Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

211 support font display for googlefonts #212

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dakebl
Copy link

@dakebl dakebl commented May 21, 2019

This PR adds a fontDisplay option to the options object that can be used to add font-display to google fonts imports.

Resolves #211

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #212 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   98.26%   98.29%   +0.03%     
==========================================
  Files          43       43              
  Lines         230      235       +5     
  Branches       17       18       +1     
==========================================
+ Hits          226      231       +5     
  Misses          4        4
Impacted Files Coverage Δ
packages/react-typography/src/GoogleFont.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e3d57...84d5eaf. Read the comment docs.

@i8ramin
Copy link

i8ramin commented Oct 28, 2020

Hi. Any chance this will get merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for font-display
4 participants