Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormBundle] Adding Filesystem to FileFormSubmissionField #2786

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[FormBundle] Adding Filesystem to FileFormSubmissionField #2786

wants to merge 5 commits into from

Conversation

Autsider666
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #2781

ProfessorKuma
ProfessorKuma suggested changes Oct 9, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

@ProfessorKuma ProfessorKuma added this to the 5.7.0 milestone Oct 9, 2020
ProfessorKuma
ProfessorKuma approved these changes Oct 9, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat modified the milestones: 5.7.0, 5.8.0 Oct 12, 2020
@Autsider666 Autsider666 force-pushed the form-filesystem branch 2 times, most recently from 0e6a0e2 to 9af774c Compare October 13, 2020 09:07
acrobat
acrobat requested changes Jan 22, 2021
View reviewed changes
src/Kunstmaan/FormBundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileFormSubmissionField.php Outdated Show resolved Hide resolved
...stmaan/FormBundle/Tests/unit/Entity/FormSubmissionFieldTypes/FileFormSubmissionFieldTest.php Outdated Show resolved Hide resolved
...stmaan/FormBundle/Tests/unit/Entity/FormSubmissionFieldTypes/FileFormSubmissionFieldTest.php Outdated Show resolved Hide resolved
@acrobat acrobat modified the milestones: 5.8.0, 5.9.0 Mar 17, 2021
@Autsider666 @acrobat
Update src/Kunstmaan/FormBundle/Entity/FormSubmissionFieldTypes/FileF…
1f6d9f0 
…ormSubmissionField.php

Co-authored-by: Jeroen Thora <jeroenthora@gmail.com>
@acrobat acrobat modified the milestones: 5.9.0, 5.10.0 Oct 10, 2021
@acrobat acrobat removed this from the 5.10.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat requested changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Feature Type: Needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Autsider666 @acrobat @ProfessorKuma