[AllBundles] Configure asset packages and add package to asset call #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Oct 2, 2020
ProfessorKuma
approved these changes
Oct 2, 2020
dannyvw
commented
Oct 2, 2020
| ], | ||
| ], | ||
| ]; | ||
| $container->prependExtensionConfig('framework', $frameworkExtensionConfig); |
There was a problem hiding this comment.
Not sure if this is the right bundle, but there is no core bundle available. Maybe move to the admin bundle?
There was a problem hiding this comment.
Yes indeed this needs to moved to the admin bundle as most of the other bundles (if not all) have the admin bundle as a dependency. Also the minimum version needs to be bumped in those bundle composer files
There was a problem hiding this comment.
Configuration moved. Which composer files needs a change?
acrobat
reviewed
Oct 12, 2020
src/Kunstmaan/MediaBundle/DependencyInjection/KunstmaanMediaExtension.php
Outdated
Show resolved
Hide resolved
dannyvw
force-pushed
the
asset-package
branch
3 times, most recently
from
9ee3ece
to
308bb43
Compare
dannyvw
force-pushed
the
asset-package
branch
2 times, most recently
from
83a4a7e
to
5a59bbb
Compare
dannyvw
force-pushed
the
asset-package
branch
2 times, most recently
from
2c94ac0
to
19fc3c4
Compare
|
@acrobat Do you have an update for this? |
|
@dannyvw I've assigned this PR to myself, so I can test it in a real project. Can you rebase against the current master as it makes it easier to test it and have the new github actions setup here. |
|
@acrobat Done |
dannyvw
force-pushed
the
asset-package
branch
2 times, most recently
from
7dbe06d
to
21c8236
Compare
dannyvw
force-pushed
the
asset-package
branch
from
21c8236
to
565c0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure asset package in Symfony and use this for all asset calls. With this change it is possible to configure a different base_url for different assets. The generate urls are default the same as before.
Also a few changes from #2769 are added in this PR.