Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][GeneratorBundle] Commands to generate new website skeleton and default pageparts #2512

Open
wants to merge 16 commits into
base: 6.x
Choose a base branch
from

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jul 3, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

This PR introduces 2 new maker commands to generate a new (improved for symfony 4) website skeleton and a new set of default pageparts. There is also a spacer pp added to allow setting custom spacings between pageparts. The functionality, to add this pagepart automatically after a pagepart is added, is disabled by default. Some work is needed to make this fully configurable.

TODO:

  • Make a region config option to enable the auto add of a spacer pp after a regular pp
kunstmaan_page_part:
    pagetemplates:
        homepage:
            name: "Home page"
            rows:
                - regions:
                    - { name: "main", span: 12, auto_spacer: true }
            template: "pages\\home_page\\pagetemplate.html.twig"
  • Config value to specify the spacer pp FQCN
  • Deprecate the old generator commands (default site + default pp's)
  • Mark these commands as @experimental. To allow fast changes (that possibly break BC) in case of big issues
  • Cleanup command output, better feedback to the user
  • Check javascript to auto add the spacer (should append the spacer to the last added pp)
  • Remove old cookie consent twig file (and includes)
  • Default styling of quote pp
  • Use the asset() twig function where we include images instead of hardcoded paths

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the new-website-skeleton branch 3 times, most recently from a8cac92 to 8584800 Compare July 8, 2019 09:03
@acrobat acrobat changed the title [GeneratorBundle] Commands to generate new website skeleton and default pageparts [WIP][GeneratorBundle] Commands to generate new website skeleton and default pageparts Sep 18, 2019
@acrobat acrobat modified the milestones: 5.4.0, 5.5.0 Dec 13, 2019
@acrobat acrobat modified the milestones: 5.5.0, Unknown (WIP) Jan 23, 2020
@acrobat acrobat changed the base branch from master to 6.x July 14, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants