Remove others getError() usage

Kunena · May 1, 2024 · 70a82e5 · 70a82e5
1 parent 398b628
commit 70a82e5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/site/language/en-GB/en-GB.com_kunena.views.ini b/src/site/language/en-GB/en-GB.com_kunena.views.ini
@@ -120,7 +120,7 @@ COM_KUNENA_MODERATION_ENTER_TOPIC = "Manually Enter Topic ID"
 COM_KUNENA_MODERATION_MERGE_TOPIC = "Merge topic with another topic"
 COM_KUNENA_POST_EDIT = "Edit Post:"
 COM_KUNENA_POST_NEW_TOPIC = "New Topic"
-COM_KUNENA_POST_NEW_TOPIC_NO_PERMISSIONS = "You do not have permissions to start a new topic! Or you haven't created/published a top level category ! %s"
+COM_KUNENA_POST_NEW_TOPIC_NO_PERMISSIONS = "You do not have permissions to start a new topic! Or you haven't created/published a top level category !"
 COM_KUNENA_POST_REPLY_TOPIC = "Reply Topic:"
 COM_KUNENA_REPLY_USER_REPLY_DISABLED = "You cannot reply to this topic."
 COM_KUNENA_SELECT_CATEGORY = "- Select Category -"

diff --git a/src/site/src/Controller/Topic/Form/Create/TopicFormCreateDisplay.php b/src/site/src/Controller/Topic/Form/Create/TopicFormCreateDisplay.php
@@ -182,9 +182,8 @@ protected function before()
         }
 
         if (!$this->topic->category_id) {
-            throw new KunenaExceptionAuthorise(Text::sprintf(
-                'COM_KUNENA_POST_NEW_TOPIC_NO_PERMISSIONS',
-                $this->topic->getError()
+            throw new KunenaExceptionAuthorise(Text::_(
+                'COM_KUNENA_POST_NEW_TOPIC_NO_PERMISSIONS'            
             ), $this->me->exists() ? 403 : 401);
         }
 

diff --git a/src/site/src/View/Topic/HtmlView.php b/src/site/src/View/Topic/HtmlView.php
@@ -1265,8 +1265,7 @@ protected function DisplayCreate($tpl = null)
         list($this->topic, $this->message) = $this->category->newTopic($saved);
 
         if (!$this->topic->category_id) {
-            $msg = Text::sprintf('COM_KUNENA_POST_NEW_TOPIC_NO_PERMISSIONS', $this->topic->getError());
-            $this->app->enqueueMessage($msg, 'error');
+            $this->app->enqueueMessage(Text::_('COM_KUNENA_POST_NEW_TOPIC_NO_PERMISSIONS'), 'error');
 
             return false;
         }