Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image upload path config #346

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

JoseMarkos
Copy link
Contributor

No description provided.

@guardrails
Copy link

guardrails bot commented Aug 17, 2022

⚠️ We detected 1 security issue in this pull request:

Insecure File Management (1)
Docs Details
💡 Title: FileSystem function with user input, Severity: Medium
$this->_path = dirname($_SERVER['SCRIPT_FILENAME']) . $path;

More info on how to fix Insecure File Management in PHP.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joanhey
Copy link
Member

joanhey commented Aug 23, 2022

Hola @JoseMarkos
Me gusta el cambio, pero creo que sería mejor crear un config para el update config/update.php.
Y le podremos añadir más cosas.

Posiblemente más adelante también quitemos el $_SERVER[], no es necesario.

Y mejor si creas un PR separado para el cambio del view, son 2 cambios diferentes.
Gracias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants