Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @code_src #253

Closed
wants to merge 5 commits into from
Closed

add @code_src #253

wants to merge 5 commits into from

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Dec 7, 2021

image

@Moelf
Copy link
Contributor Author

Moelf commented Dec 7, 2021

if macro name and implementation are good with you, I will add documentation and tests @KristofferC

@KristofferC
Copy link
Owner

Seems OK to me but I wonder a bit how useful this is in practice. By using @edit you open your editor which also has highlighting.

@Moelf
Copy link
Contributor Author

Moelf commented Dec 7, 2021

I think:
JuliaLang/julia#2625 (comment)

one might want to take screenshot with context for comparison, commentary

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021

Codecov Report

Merging #253 (3115558) into master (786e947) will increase coverage by 1.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   19.28%   20.89%   +1.60%     
==========================================
  Files          12       13       +1     
  Lines         866      876      +10     
==========================================
+ Hits          167      183      +16     
+ Misses        699      693       -6     
Impacted Files Coverage Δ
src/CodeTracking.jl 100.00% <100.00%> (ø)
src/OhMyREPL.jl 19.04% <100.00%> (+4.41%) ⬆️
src/repl_pass.jl 60.00% <0.00%> (+1.93%) ⬆️
src/passes/SyntaxHighlighter.jl 48.71% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786e947...3115558. Read the comment docs.

@Moelf Moelf force-pushed the code_src branch 2 times, most recently from c607ded to 1763ffd Compare December 11, 2021 16:26
@Moelf
Copy link
Contributor Author

Moelf commented Dec 11, 2021

@KristofferC pretty sure docs build fail is unrelated

@Moelf
Copy link
Contributor Author

Moelf commented Feb 4, 2022

bump

@Moelf
Copy link
Contributor Author

Moelf commented May 6, 2022

gentle bump

@KristofferC
Copy link
Owner

Sorry for the slow response here. I've been hardcore neglecting this package for quite a while.

Looking at this with fresh eyes I don't think it really fits very well in here. And the way this is implemented by adding a whole new macro as a side effect of loading another package is quite unusual. Typically, you want to add a method extension but that is kind of hard to macros. And I also don't really want to add a dependency on Requires.

@KristofferC KristofferC closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants