Switch to using topLayoutGuide to determine vertical offset #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlorich
changed the title
| CGFloat verticalOffset = [[currentView.viewController topLayoutGuide] length]; | ||
|
|
||
| if ([currentView.viewController isKindOfClass:[UINavigationController class]]) { | ||
| verticalOffset += ((UINavigationController *)currentView.viewController).toolbar.frame.size.height; |
There was a problem hiding this comment.
While this works, it doesn't adapt when the top layout guide changes (such as if the user changes the orientation of their device).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #130 .
The status bar height changes based on in-call or navigation status, however if the ViewController has an
autoResizingMaskofUIViewAutoresizingFlexibleTopMarginthe ViewControllers view will already be adjusted for the increased status bar size. If a TSMessage is displayed when this is the case, it will show 24px below the navigation bar as the view is automatically adjusted for the statusBar height change, and then the TSMessageView is additionally moved down based on the new status bar size.To fix this issue, I've changed the display position to use the viewControllers
[topLayoutGuide length]as the vertical offset, as it already takes into account navigation bar and status bar size correctly. Adjustments have also been made for when the viewController is aUINavigationControllersubclass, since it's view is handled a bit differently.