Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom view for TSMessage (model and view) #134

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

XBeg9
Copy link

@XBeg9 XBeg9 commented Apr 10, 2014

Now we can subclass and create own controls under TSMessageView.
I have also separate view and model (item).
Please check example TSMessageCustomItem and TSMessageCustomView.

TSMessageCustomItem *item = [TSMessageCustomItem itemWithTitle:@"Test" subtitle:@"description" type:TSMessageNotificationTypeSuccess inViewController:self tapHandler:^(TSMessageCustomItem *item) {
        NSLog(@"Message did pressed");
    } iconHandler:^(TSMessageCustomItem *item) {
        NSLog(@"Icon did pressed");
    } disclosureView:nil disclosureHandler:^(TSMessageCustomItem *item) {
        NSLog(@"Disclosure view did pressed");
    }];
[TSMessage showNotificationMessageWithItem:item];

@KrauseFx
Copy link
Owner

Wow, this Pull Request is huge! Thanks a lot for your contribution.
I hope I'll get to take a look at it in the next days.

@dennisreimann
Copy link
Contributor

@KrauseFx please check whether or not it has any implications when we would later try to integrate this into the develop branch

@mRs-
Copy link
Collaborator

mRs- commented Apr 16, 2014

So what's the real deal here? Are we going to implement this in the 0.X Versions and rebuild this from the scratch in the 1.X develop branch?

@mRs- mRs- mentioned this pull request Apr 16, 2014
@KrauseFx
Copy link
Owner

@mRs- I think this should be in the 1.0 release. On the first glance, this PR looks really great and offers a nice way for developers to extend the functionality of TSMessages without touching the core.
I still want to take a look at all changes in detail.

How about merging this PR into the develop branch and experiment with it a little?

@XBeg9
Copy link
Author

XBeg9 commented Apr 17, 2014

Added fix for height calculation.

@XBeg9
Copy link
Author

XBeg9 commented Apr 17, 2014

@KrauseFx I am apologize in advance if something is not developed carefully, it took me only 1 night for very urgent project. I haven't enough time now to clean everything, but if you want me to help in something don't hesitate.

@mkantor
Copy link

mkantor commented Jul 23, 2014

Any chance of seeing this (or something like it) implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants