few cosmetic changes and with C++17 no need to explictly define copy … #607

devnexen · 2022-08-09T21:17:00Z

…constructors.

caiiiycuk · 2022-08-10T23:25:36Z

lib/xsound/ogg_stream.cpp

-OggStream::OggStream(const std::string &fname) {
-	_file = fopen(fname.c_str(), "rb");
+OggStream::OggStream(const std::string_view fname) {
+	_file = fopen(fname.data(), "rb");


why data is more preferable then c_str()?

simply because there is no such things with string_view :-) it s chunk of bytes that s how it gains perf over a traditional std string, no need allocation.

https://en.cppreference.com/w/cpp/string/basic_string_view

stalkerg · 2022-08-13T03:07:52Z

Firstly I should migrate it to flatpack for steam, before we can use C++17.

devnexen added 2 commits August 9, 2022 22:15

few cosmetic changes and with C++17 no need to explictly define copy …

3958c0d

…constructors.

using more C++17 facilities.

b23519c

caiiiycuk reviewed Aug 10, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

few cosmetic changes and with C++17 no need to explictly define copy … #607

few cosmetic changes and with C++17 no need to explictly define copy … #607

devnexen commented Aug 9, 2022

caiiiycuk Aug 10, 2022 •

edited

devnexen Aug 11, 2022 •

edited

stalkerg commented Aug 13, 2022

few cosmetic changes and with C++17 no need to explictly define copy … #607

Are you sure you want to change the base?

few cosmetic changes and with C++17 no need to explictly define copy … #607

Conversation

devnexen commented Aug 9, 2022

caiiiycuk Aug 10, 2022 • edited

Choose a reason for hiding this comment

devnexen Aug 11, 2022 • edited

Choose a reason for hiding this comment

stalkerg commented Aug 13, 2022

caiiiycuk Aug 10, 2022 •

edited

devnexen Aug 11, 2022 •

edited