Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum length password wording (character number) #792

Merged
merged 6 commits into from May 23, 2024

Conversation

m0nhawk
Copy link

@m0nhawk m0nhawk commented May 3, 2024

I noticed the actual wording is different than the actual behavior.

Wording says 10 characters limit:
Screenshot from 2024-05-03 01-13-50

But the behavior is 8 characters.
Screenshot from 2024-05-03 01-14-11

@Kovah
Copy link
Owner

Kovah commented May 3, 2024

Thanks for taking your time to fix these errors. Unfortunately, translations are handled in Crowdin and moving committed changes back into the translation system is more work than changing it there. If you have an account there and you're willing to redo it there, let me know. Otherwise I will make them myself.

@m0nhawk
Copy link
Author

m0nhawk commented May 3, 2024

I missed that, I can update Crowdin through the weekend. 👍

@m0nhawk m0nhawk closed this May 3, 2024
@m0nhawk m0nhawk reopened this May 8, 2024
@m0nhawk
Copy link
Author

m0nhawk commented May 8, 2024

@Kovah I've submitted the Crowdin suggestions, and I think the en_US still needs to be fixed in code (and the tests).

@Kovah Kovah changed the base branch from main to dev May 8, 2024 08:15
@Kovah
Copy link
Owner

Kovah commented May 8, 2024

Awesome, many thanks!

@Kovah
Copy link
Owner

Kovah commented May 8, 2024

Hm, something doesn't seem right. Will have a look later.

@m0nhawk
Copy link
Author

m0nhawk commented May 9, 2024

I noticed that the test was failing because of minimal character number in artisan cli, I have committed the fix - now it will match the other parts and 8 characters.

@m0nhawk m0nhawk requested a review from Kovah May 14, 2024 02:33
@Kovah Kovah merged commit 3d156fc into Kovah:dev May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants