Change content without page refreshing #2727
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
feature-dynamic-pages
branch
from
ae62b89
to
ce3bc84
Compare
nikpachoo
reviewed
Dec 15, 2022
Comment on lines
+17
to
+20
| document.querySelectorAll("#sideMenu a") | ||
| .forEach(elem => elem.addEventListener('click', (event) => selectPage(event, elem))) | ||
| document.querySelectorAll("#main a") | ||
| .forEach(elem => elem.addEventListener('click', (event) => selectPage(event, elem))) |
There was a problem hiding this comment.
I'd recommend using event delegation than adding an event listener for each element:
- Total memory footprint goes down. It can be significant for an application with many pages in the TOC (StdLib)
- Help prevent memory leaks. With event delegation, you can destroy child elements without the risk of forgetting to "unbind" their event listeners.
- Supports DOM modifications: you can add new elements later, and the event will catch them.
- Simplifies initialization — no need to wait for all elements to be inserted into DOM.
| document.querySelectorAll("#sideMenu a") | ||
| .forEach(elem => elem.addEventListener('click', (event) => selectPage(event, elem))) | ||
| document.querySelectorAll("#main a") | ||
| .forEach(elem => elem.addEventListener('click', (event) => selectPage(event, elem))) | ||
| }).then(() => { |
There was a problem hiding this comment.
Just an advise for code style improvement.
I noticed that there is a chain with many then functions inside displayNavigationFromPage function.
The thing is that they useless, only the first does matter. So, all then blocks can be collapsed to the first one.
Comment on lines
+65
to
+66
| document.querySelectorAll("#main a") | ||
| .forEach(elem => elem.addEventListener('click', (event) => selectPage(event, elem))) |
There was a problem hiding this comment.
I guess these event listeners were initialized before the comment about event delegation was written by me.
|
Hey, any update on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2150