Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities): restore Teleport for new entity button only in Konnect app [KHCP-11277] #1383

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mptap
Copy link
Contributor

@mptap mptap commented May 1, 2024

Summary

https://konghq.atlassian.net/browse/KHCP-11277

Consumed in https://github.com/Kong/konnect-ui-apps/pull/3087
Deploy Preview: https://pr-3087--gateway-manager.cloud-preview.konghq.tech/gateway-manager

This is an easier solution to avoid the Teleport target warning for Kong Manager by not conditionally rendering this for Kong Manager.

Context: This PR introduced the regression #1001
where dynamic component usage for Teleport (instead of constantly using a Teleport component) was resulting in the content being always rendered as a div and never a Teleport

(seems dynamic component and Teleport just don’t work well together).

Summary of next steps:
cc: @Leopoldthecoder

  1. Add destination div for the Teleport <div id="kong-ui-app-page-header-action-button"/>
    in all of the Kong Manager GM entities.

  2. Disable the Vue warning fix(teleport): not throw warning when teleport is disabled by Leopoldthecoder · Pull Request #9818 · vuejs/core
    Thanks @Yi Yang for opening this PR up.
    Hopefully we can get this merged soon.

  3. Revert the dynamic component PR #1001.

  4. Close this PR without merging.

@mptap mptap self-assigned this May 1, 2024
@mptap mptap marked this pull request as ready for review May 1, 2024 17:02
@mptap mptap requested review from a team as code owners May 1, 2024 17:02
@mptap mptap force-pushed the fix/teleport-new-entity-button-align-book-icon-khcp-11277 branch from 933997c to 1aa1fc1 Compare May 2, 2024 16:43
@mptap
Copy link
Contributor Author

mptap commented May 2, 2024

@kaiarrowood I tried implementing with the fallback div method moved outside of the KTable in the last 3 commits but that doesn't work when useActionOutside prop isn't supplied (like in Kong Manager) and I get the following Vue warnings.
Screenshot 2024-05-02 at 10 18 31 AM

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-shared@pr-1383
@kong-ui-public/dashboard-renderer@pr-1383
@kong-ui-public/documentation@pr-1383
@kong-ui-public/entities-certificates@pr-1383
@kong-ui-public/entities-consumer-credentials@pr-1383
@kong-ui-public/entities-consumer-groups@pr-1383
@kong-ui-public/entities-consumers@pr-1383
@kong-ui-public/entities-data-plane-nodes@pr-1383
@kong-ui-public/entities-gateway-services@pr-1383
@kong-ui-public/entities-key-sets@pr-1383
@kong-ui-public/entities-keys@pr-1383
@kong-ui-public/entities-routes@pr-1383
@kong-ui-public/entities-snis@pr-1383
@kong-ui-public/entities-upstreams-targets@pr-1383
@kong-ui-public/entities-vaults@pr-1383
@kong-ui-public/entities-plugins@pr-1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants