feat(analytics-chart): experimenting with legend styling #1240
+71
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgutica
requested changes
Mar 27, 2024
packages/analytics/analytics-chart/src/components/chart-plugins/ChartLegend.vue
Outdated
Show resolved
Hide resolved
filipgutica
requested changes
Mar 27, 2024
filipgutica
reviewed
Mar 27, 2024
packages/analytics/analytics-chart/src/components/chart-plugins/ChartLegend.vue
Outdated
Show resolved
Hide resolved
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
filipgutica
requested changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@filipgutica This is an attempt to simplify the Legend height conundrum, and keep it styled via pure CSS (thus allowing us to do away with the bound CSS variable).
Using color squares instead of lines, and also left-aligning the legend (roughly in line w/ the Y-Axis labels)
Resources