Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): labels for plugin config fields #1030

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Dec 22, 2023

Summary

This PR fixes issues like letter cases, abbreviations, etc. with labels used in the unified plugin forms. It also removes redundant /^[Cc]onfig\./ prefixes from labels as we no longer display them.

Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito
Copy link
Member Author

As this would also be effective for Konnect UI, I would like to have these changes reviewed by @Kong/team-core-ui as well. Please merge this PR if it looks good. Thanks!

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/forms@pr-1030
@kong-ui-public/entities-plugins@pr-1030

@sumimakito
Copy link
Member Author

Update:

Fix the help text of the config.issuer field with a custom override because the BE schema is too general.

Before After
Screenshot 2023-12-25 at 11 18 11 Screenshot 2023-12-25 at 11 17 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants