Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: non blocking fetch on navigate #7321

Merged
merged 5 commits into from Apr 29, 2024

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Apr 25, 2024

Removes the blocking fetch on organisation navigate

Instead makes a non-blocking request whenever one of three components is loaded, including project which might be a wasteful call but can be cached out of scope.

  • test that it refetches on org change

note: from #7318

future work

  • use SSE to control re-fetching and use cache for initial state if available

@jackkav jackkav force-pushed the fix/non-blocking-permissions branch from 14dc1ed to 8f8aec2 Compare April 29, 2024 09:04
@jackkav jackkav enabled auto-merge (squash) April 29, 2024 09:17
@jackkav jackkav merged commit 27922a8 into Kong:develop Apr 29, 2024
7 checks passed
@jackkav jackkav deleted the fix/non-blocking-permissions branch April 29, 2024 09:19
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request May 8, 2024
* non-blocking action loader

* fix types

* improve plugin logging

* use keys to make org change refetch

* Update packages/insomnia/src/ui/components/panes/project-empty-state-pane.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants