chore: CP version updated in samples #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
update-samples
branch
from
f7c5d7d
to
bc754fe
Compare
pmalek
reviewed
Apr 30, 2024
| @@ -13,7 +13,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: controller | |||
| image: kong/kubernetes-ingress-controller:3.1 | |||
| image: kong/kubernetes-ingress-controller:3.1.4 | |||
There was a problem hiding this comment.
This all depends on the imagePullPolicy (which we do not set) and the defaulting behavior.
My take on this is that we'd want to add renovate code markers here so that we do not need to bump those anymore. WDYT?
cc: @lahabana for enabling renovate on this repo.
There was a problem hiding this comment.
Yep, it'd be great to have these automatically bumped 👍
|
Closing in favor of the introduced renovate setup. |
auto-merge was automatically disabled
May 20, 2024 20:13
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes