Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request-termination and forward-proxy incompatibility #7358

Merged

Conversation

damiang3008
Copy link
Contributor

@damiang3008 damiang3008 commented May 9, 2024

Description

Clarification: the plugin won't execute if if forward-proxy is enabled (valid for all versions)
Jira: https://konghq.atlassian.net/browse/FTI-5909
Kong idea reported to review the plugin priority: https://kong-internal-portal.ideas.aha.io/ideas/GTWY-I-886

Testing instructions

Preview link: https://deploy-preview-7358--kongdocs.netlify.app/hub/kong-inc/request-termination/

Checklist

Clarification: the plugin won't execute if if forward-proxy is enabled
Jira: https://konghq.atlassian.net/browse/FTI-5909
Kong idea reported to review the plugin priority: https://kong-internal-portal.ideas.aha.io/ideas/GTWY-I-886
@damiang3008 damiang3008 added the review:copyedit Request for writer review. label May 9, 2024
@damiang3008 damiang3008 requested a review from a team as a code owner May 9, 2024 15:36
Copy link

netlify bot commented May 9, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 50443b3
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6644e7c854fe990008a84f5b
😎 Deploy Preview https://deploy-preview-7358--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lena-larionova lena-larionova merged commit 16675dd into main May 15, 2024
15 checks passed
@lena-larionova lena-larionova deleted the request-termination-forward-proxy-incompatibility branch May 15, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants