Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added example in javascript custom plugin #7349

Merged
merged 2 commits into from May 22, 2024
Merged

added example in javascript custom plugin #7349

merged 2 commits into from May 22, 2024

Conversation

gforns
Copy link
Contributor

@gforns gforns commented May 6, 2024

Description

  • added example configuration for Javascript custom plugins
  • added some required dependency when running TypeScript

Testing instructions

Preview link:

Checklist

@gforns gforns added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label May 6, 2024
@gforns gforns requested a review from a team as a code owner May 6, 2024 15:20
@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 93663c9
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/664e744c46e5570009871400
😎 Deploy Preview https://deploy-preview-7349--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 92 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

lena-larionova
lena-larionova reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with very minor edits, thanks for adding this!

app/_src/gateway/plugin-development/pluginserver/javascript.md Outdated Show resolved Hide resolved
app/_src/gateway/plugin-development/pluginserver/javascript.md Outdated Show resolved Hide resolved
app/_src/gateway/plugin-development/pluginserver/javascript.md Outdated Show resolved Hide resolved
app/_src/gateway/plugin-development/pluginserver/javascript.md Outdated Show resolved Hide resolved
app/_src/gateway/plugin-development/pluginserver/javascript.md Outdated Show resolved Hide resolved
@lena-larionova lena-larionova merged commit d504fe8 into main May 22, 2024
15 checks passed
@lena-larionova lena-larionova deleted the gforns-patch-2 branch May 22, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gforns @lena-larionova