Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tries to fix the broken CI workflows #7319

Closed
wants to merge 3 commits into from
Closed

Conversation

n0vad3v
Copy link
Contributor

@n0vad3v n0vad3v commented Apr 28, 2024

Description

Tries to fix the broken CI workflows in PR.

Testing instructions

Preview link:

Checklist

@n0vad3v n0vad3v requested a review from a team as a code owner April 28, 2024 15:15
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 07f02f9
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/662f0a5deb018c00080c0daf
😎 Deploy Preview https://deploy-preview-7319--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 94 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@n0vad3v n0vad3v changed the title Try adding permission to workflow Tries to fix the broken CI workflows Apr 28, 2024
@n0vad3v
Copy link
Contributor Author

n0vad3v commented Apr 28, 2024

Hmmm, maybe it's needed to adjust permissions at https://github.com/organizations/Kong/settings/actions to allow GITHUB_TOKEN for more privileges

Screenshot from 2024-04-28 23-27-24

Otherwise, even manually set:

    permissions:
      contents: write
      issues: write
      pull-requests: write

theses permissions at workflow will still result in

GITHUB_TOKEN Permissions
  Contents: read
  Issues: read
  Metadata: read
  PullRequests: read

in actual run.

Screenshot from 2024-04-28 23-26-03

@cloudjumpercat cloudjumpercat added the review:tech Request for technical review on the docs platform or processes. label Apr 29, 2024
@n0vad3v n0vad3v mentioned this pull request May 1, 2024
2 tasks
@mheap
Copy link
Member

mheap commented May 2, 2024

The issue here is that the action triggers on pull_request rather than pull_request_target, which doesn't have access to secrets when the contributor is submitting from a fork.

Switching to pull_request_target is ok in this instance as executing the check from main is preferred 99% of the time

@n0vad3v
Copy link
Contributor Author

n0vad3v commented May 16, 2024

@mheap Got it, 😃, so maybe it's save to close this PR now.

@n0vad3v n0vad3v closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants