Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crd) add a CRD-checking system #895

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(crd) add a CRD-checking system #895

wants to merge 1 commit into from

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Oct 5, 2023

What this PR does / why we need it:

Add a CRD version index and failure condition when the installed CRDs are below the requested level. On failure, chart actions will print a message with the update command.

One of the options from #890

Special notes for your reviewer:

The CRD annotation this check relies on does not exist yet. We can add it with additional configuration in KIC's config/crd/kustomization.yaml:

commonAnnotations:
  konghq.com/kic-crd-release: 2.9.0

Draft pending additional testing and possibly some mechanism for less manual version maintenance.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant