Fix DSKIO driver error check in DOS 1, page 1 transfers #134
Conversation
The code in drv.mac was assuming that the call to the driver routine DEV_RW/DSKIO was setting Cy=1 to signal an error, however this is true only for drive-based drivers, but not for device-based drivers. This incorrect behavior was happening only in DOS 1 mode and only for transfers to page 1.
|
Hi @S0urceror, would you like to take a look at this? |
|
Looks like an elegant solution. You have a new DIO_DO_CALDRV function that checks the return based on KSLOT in DIO_SET_ERR_FLAG. Forgive me but I'm a bit lost in Github wizardry. What release/branch do you recommend me to try this out (fix-driver-error-check-in-dskio)? I can check with my USB drivers on MSX1 and 2 if all works there. On the other hand, what can go wrong, it's a straightforward fix. |
|
@S0urceror Indeed, in order to test this you should checkout the |
|
I have checked out the fix-driver-error-check-in-dskio branch and built Nextor with my MSXUSB and MSXUSBNext driver. I can confirm both work on an MSX1 and an MSX2. So looks good and stable. |
Awesome, thanks for checking! |
This pull request fixes code in
drv.macthat was assuming that the driver routineDEV_RW/DSKIOsets Cy=1 to signal an error, however this is true only for drive-based drivers, but not for device-based drivers. This incorrect behavior was happening only in DOS 1 mode and only for transfers to page 1.Inspired by #111.