Fix a bug in MAPDRV and a bug in the MFRSD kernel regarding DEV_STATUS routine #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MAPDRV was corrupting the register holding the drive number while unmapping all the drives in case the device reports it has changed. Thus the mapping information ended up written to an incorrect memory area. - The MFRSD driiver was reporting "device changed" even after the device had been accessed with DEV_RW. A device is no longer considered as "changed" after it has been accessed. Scenario to reproduce the issue: - MFRSD with two cards, second one has at least 2 partitions - On boot, A: is card 1 partition 1, B: is card 2 partition 1 - Right after boot map any drive to card 2 partition 2: MAPDDRV d: 2 3 1-3 - Now switch to drive D:, computer crashes
|
I don't know if it's related to the same issue but running a MFRSCC+ SD with 2 SD Cards in the same configuration (A: is SD Card 1 partition 1 and B: is SD Card 2 partition 1), mapping C: and D: to SD Card 2 partitions 2 and 3 respectively and then switching to drive B: will return a bad drive name error in Basic and switching to C: right after a failure to switch to B: will hand the computer. Somehow though, running let's say DEVINFO from drive A: before switching to drive B: will not reproduce this behavior as the partitions and drives are recognized as expected. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MAPDRVfunction call code was corrupting the register holding the drive number while unmapping all the drives assigned to the device in the case where the driver reports that the device has changed. Thus the mapping information ended up written to an incorrect memory area.The MegaFlashROM SCC+ SD driver was reporting "device changed" even after the device had been accessed with
DEV_RW. A device is no longer considered as "changed" after it has been accessed.Scenario to reproduce the issue:
MAPDDRV d: 2 3 1-3