Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment output clear option #3675

Merged
merged 1 commit into from
May 8, 2019
Merged

Comment output clear option #3675

merged 1 commit into from
May 8, 2019

Conversation

ssigwart
Copy link
Contributor

@ssigwart ssigwart commented Feb 5, 2019

Split out of #3672.

@th3coop th3coop self-requested a review February 5, 2019 18:16
@th3coop th3coop added this to the 11.1.2 milestone Feb 5, 2019
Copy link
Member

@th3coop th3coop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd say that you should use require("ko/dom") but it's not used anywhere else in this file so let's not bother. If you haven't seen/used it though, it's very similar to jquery when working with the Komodo DOM.

This works great btw. Thanks @ssigwart

@th3coop th3coop merged commit 005dafb into Komodo:master May 8, 2019
@th3coop
Copy link
Member

th3coop commented May 8, 2019

Merged into IDE

@ssigwart ssigwart deleted the cleancmds branch May 8, 2019 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants