Open Files, Command Output, and Notifications Updates

src/chrome/komodo/content/notifications/notificationsWidget.js

@@ -169,6 +169,15 @@ this.updateFilters = (function NWC_updateFilters() {
   }
 }).bind(this);
 
+/**
+ * Clear all notifications
+ */
+this.clearMessages = (function NWC_clearMessages() {
+  while (this.container.firstChild)
+    this.container.removeChild(this.container.firstChild);
+  this._map = {};
+}).bind(this);
+
 /**
  * Determine whether a given item should be shown
  * @param aElem {richlistitem} The item to check

src/chrome/komodo/content/notifications/notificationsWidget.xul

@@ -37,6 +37,9 @@
             <toolbarbutton type="checkbox" id="filter-progress"
                            tooltiptext="&filterProgressTooltip;"
                            oncommand="NotificationsWidgetController.updateFilters()"/>
+            <toolbarbutton id="notifications-clear"
+                           tooltiptext="&notificationsClearTooltip;"
+                           oncommand="NotificationsWidgetController.clearMessages()"/>
           </toolbargroup>
         </toolbar>
     </box>

src/chrome/komodo/content/run/runOutputPane.xul

@@ -78,6 +78,10 @@
                         tooltiptext="&terminateProcess.tooltiptext;"
                         oncommand="ko.run.output.kill(-1);"
                         disabled="true"/>
+                <toolbarbutton id="runoutput-clear-button"
+                        class="icon-close"
+                        tooltiptext="&clearOutput.tooltiptext;"
+                        oncommand="ko.run.output.clearOutput();" />
             </toolbar>
         </box>
 

src/chrome/komodo/content/run/runOutputWindow.js

@@ -353,6 +353,21 @@ this.kill = function RunOutput_Kill(retval)
     }
 }
 
+/** Clear */
+this.clearOutput = function RunOutput_ClearOutput()
+{
+    var descWidget = document.getElementById("runoutput-desc");
+    var cmdWidget = document.getElementById("runoutput-command");
+    descWidget.setAttribute("value", "");
+    cmdWidget.setAttribute("value", "");
+
+    // Clear session
+    if (_gTerminalView && !_gTerminalHandler.active)
+    {
+        _gTerminalView.startSession(true);
+        _gTerminalView.endSession();
+    }
+}
 
 function _SetView(editor, showParsedOutputList)
 {

src/chrome/komodo/locale/en-US/komodo.dtd

@@ -54,6 +54,7 @@
 <!ENTITY checkForUpdates.label "Check for Updates...">
 <!ENTITY checkSyntaxNow.label "Check syntax now">
 <!ENTITY cleanLineEndings.label "Clean Line Endings">
+<!ENTITY clearOutput.tooltiptext "Clear Output">
 <!ENTITY clearSearchHighlighting.label "Clear Highlighting">
 <!ENTITY clearWarningErrorSquigglies.label "Clear warning/error squigglies">
 <!ENTITY close.label "Close">

src/chrome/komodo/locale/en-US/notifications.dtd

@@ -2,4 +2,5 @@
 <!ENTITY filterWarningTooltip  "Toggle whether warnings are shown">
 <!ENTITY filterInfoTooltip     "Toggle whether informational messages are shown">
 <!ENTITY filterProgressTooltip "Toggle whether to limit to in-progress tasks">
+<!ENTITY notificationsClearTooltip "Clear all messages">
 <!ENTITY filterSearchEmpty     "Filter messages">

src/chrome/komodo/skin/global/icons.less

@@ -324,6 +324,7 @@ richlistitem.file-item[view-type="browser"]
     #filter-warning { .icon(); .icon-exclamation-circle(); }
     #filter-info { .icon(); .icon-info-circle(); }
     #filter-progress { .icon(); .icon-clock-o(); }
+    #notifications-clear { .icon(); .icon-close(); }
 }
 
 .scrollbutton-up

src/chrome/komodo/skin/notifications.css

@@ -21,6 +21,9 @@
 #filter-progress {
   list-style-image: url("chrome://fugue/skin/icons/clock-history.png");
 }
+#notifications-clear {
+  list-style-image: url("chrome://global/skin/icons/close.png");
+}
 
 #filter-search {
   -moz-box-flex: 1;

src/chrome/komodo/skin/plat/shared/icons_rules.less

@@ -1616,6 +1616,11 @@ ko-pane[type="icons"]
     {
         list-style-image: @icon-filter-progress !important;
     }
+
+    #notifications-clear
+    {
+        list-style-image: @icon-close !important;
+    }
 }
 
 /* Syntax checking widget */

src/modules/openfiles/content/openfiles.js

@@ -39,6 +39,13 @@ if (typeof ko.openfiles == 'undefined')
     var groupOptions        = {};
     var sortOptions         = {};
 
+    /** Filters.  Array of arrays.  First dimension is an AND.  Second is an OR. */
+    var filters = [];
+
+    /** File separator */
+    const system = require("sdk/system");
+    const sep = system.platform == "winnt" ? "\\" : "/";
+
     /* Keep track of listeners so we can remove them if needed */
     var listeners            = {};
 
@@ -91,6 +98,9 @@ if (typeof ko.openfiles == 'undefined')
             template.groupItem.removeAttribute('id')
             tpl.parentNode.removeChild(tpl);
 
+            // Disables select handler
+            this._disableSelectHandler = false;
+
             // Register built in sorting options
             this.registerSortOption(
                 'byName',
@@ -449,7 +459,7 @@ if (typeof ko.openfiles == 'undefined')
 
             /**** OpenFiles Events ******/
             listbox.addEventListener('select', function(e) {
-                if (e.target == listbox && e.target.selectedItem)
+                if (e.target == listbox && e.target.selectedItem && !this._disableSelectHandler)
                 {
                     this.selectItem(e.target.selectedItem, true /*sendEditorTabClick*/ );
                     ko.commands.doCommandAsync('cmd_focusEditor')
@@ -658,6 +668,8 @@ if (typeof ko.openfiles == 'undefined')
          */
         drawList: function openfiles_drawList(noDelay = false)
         {
+            var hasRemovedItems = false;
+
             // Prevent multiple calls in a short amount of time (10ms)
             if ( ! noDelay) {
                 clearTimeout(timers.drawList || {});
@@ -671,14 +683,58 @@ if (typeof ko.openfiles == 'undefined')
             // Iterate through open views and append them to the list 
             for (let uid of Object.keys(openViews))
             {
+                // Get view
+                var editorView  = openViews[uid];
+
+                // Check filters
+                var foundInFilter = true;
+                if (filters.length > 0)
+                {
+                    var dirName = editorView.koDoc.file ? editorView.koDoc.file.dirName : '';
+                    var file = dirName + sep + editorView.title;
+                    file = file.toLowerCase();
+
+                    // Check AND filters
+                    for (var filterIdx = 0; filterIdx < filters.length; filterIdx++)
+                    {
+                        // Check OR filters
+                        var orFilters = filters[filterIdx];
+                        var foundInOr = false;
+                        for (var orFiltersIdx = 0; orFiltersIdx < orFilters.length; orFiltersIdx++)
+                        {
+                            if (file.indexOf(orFilters[orFiltersIdx]) !== -1)
+                            {
+                                foundInOr = true;
+                                break;
+                            }
+                        }
+                        if (!foundInOr)
+                        {
+                            foundInFilter = false;
+                            break;
+                        }
+                    }
+                }
+
                 // Skip items that are already in the list
-                if (listbox.querySelector('richlistitem[id="'+uid+'"]'))
+                var existingItem = listbox.querySelector('richlistitem[id="'+uid+'"]');
+                if (existingItem !== null)
                 {
+                    // Remove if shouldn't be in list
+                    if (!foundInFilter)
+                    {
+                        hasRemovedItems = true;
+                        existingItem.parentNode.removeChild(existingItem);
+                    }
+
                     continue;
                 }
-
+
+                // Skip if not found in filters
+                if (!foundInFilter)
+                    continue;
+
                 // Append the item
-                var editorView  = openViews[uid];
                 var listItem    = listbox.appendChild(
                                     this.createListItem(editorView));
 
@@ -691,7 +747,11 @@ if (typeof ko.openfiles == 'undefined')
                     this.selectItem(editorView);
                 }
             }
-
+
+            // Remove empty groups caused by removed items
+            if (hasRemovedItems)
+                this.removeEmptyGroups();
+
             // Render the groups and splits
             this.drawGroups();
             this.updateLabelCounter();
@@ -1906,8 +1966,25 @@ if (typeof ko.openfiles == 'undefined')
         {
             var groupOption = ko.prefs.getString(PREF_GROUPING_TYPE, 'byLanguage');
             return groupOptions[groupOption];
+        },
+
+        /** Update filters */
+        updateFilters: function openfiles_updateFilters()
+        {
+            filters = [];
+            var textSearch = document.getElementById("filter-search").value.toLowerCase().trim();
+            if (textSearch.length > 0)
+            {
+                for (var word of textSearch.split(/\s+/))
+                    filters.push(word.split("|"));
+            }
+
+            // Redraw list
+            var orig_disableSelectHandler = this._disableSelectHandler;
+            this._disableSelectHandler = true;
+            this.drawList(true);
+            this._disableSelectHandler = orig_disableSelectHandler;
         }
-
     };
 
     ko.openfiles = new ko.openfiles();

src/modules/openfiles/content/panel.xul

@@ -216,6 +216,13 @@
                     tooltiptext="&closeFiles.tooltip;"/>
 
             </richlistitem>
+            <box class="widgetToolbarWrap centered">
+                <textbox id="filter-search" flex="1"
+                 emptytext="&openFiles.filterSearch;" type="search"
+                         oninput="ko.openfiles.updateFilters();"
+                         oncommand="ko.openfiles.updateFilters();" />
+                <separator flex="1"/>
+            </box>
         </vbox>
     </vbox>
 

src/modules/openfiles/locale/en-US/openfiles.dtd

@@ -1,4 +1,5 @@
 <!ENTITY openFiles.label "Open Files">
+<!ENTITY openFiles.filterSearch "Filter Files">
 <!ENTITY viewEditorTabs.label "Show Editor Tabs">
 <!ENTITY viewEditorTabs.tooltip "Toggle Editor Tabs">
 <!ENTITY closeFile.tooltip "Close File">