[Search Dialogs] Remove singleton for dialog #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugwelle
force-pushed
the
singletons-dialog
branch
from
68ce425
to
0990ba0
Compare
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
=========================================
- Coverage 6.55% 6.55% -0.01%
=========================================
Files 431 431
Lines 33764 33793 +29
=========================================
Hits 2214 2214
- Misses 31550 31579 +29
Continue to review full report at Codecov.
|
bugwelle
force-pushed
the
singletons-dialog
branch
from
0990ba0
to
4cc6cf3
Compare
|
Tested locally. Everything seems to work just fine. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singletons need to be initialized at startup. This is not needed for dialogs like "TvShowSearch.ui". It only makes MediaElch start slower and makes it use more RAM.
See #847