[File] Add Filesystem class for better testing #1291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea was to pass an explicit file system object to each class that handles files. However, I now think that having global functions or at least a singleton isn't bad in this case. Simply because we're not a library, we're an app. Having a central place that handles files is useful here. |
The idea is to have a central place that properly logs file accesses. The class could potentially be mocked as well.
bugwelle
force-pushed
the
mock-filesystem
branch
from
ef76a93
to
c974533
Compare
|
Further ideas:
|
|
Discarding. See #847 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.