Add ability to set breathe in hold duration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattChubb
force-pushed
the
more-config
branch
from
7a549cb
to
06998e7
Compare
MattChubb
force-pushed
the
more-config
branch
from
06998e7
to
88e3b99
Compare
Koenkk
reviewed
Nov 12, 2023
src/app/helper.ts
Outdated
| {duration: 30, breatheInHold: 15}, | ||
| {duration: 60, breatheInHold: 15}, | ||
| {duration: 90, breatheInHold: 15}], | ||
| schemeLevel: 1 |
There was a problem hiding this comment.
The schemeLevel should be bumped and a migration should be done in getSettings
There was a problem hiding this comment.
I've added a migrateSettings function to migrate from v1 to v2 automatically, but not sure this is the cleanest way to do it?
Koenkk
reviewed
Nov 12, 2023
| onClick={() => this.removeRound(round)} | ||
| /> | ||
| </div> | ||
| <Card variant="outlined" style={{ |
There was a problem hiding this comment.
I notice the retention time is now duplicated, makes sense to move it to round?
MattChubb
force-pushed
the
more-config
branch
from
104228c
to
f4bfae8
Compare
|
I also noticed the CICD is failing. I think I need to set something up for gh-pages to work properly? |
2 remarks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted the ability to configure the breathe in hold to something other than 15sec, so I added it as a configurable setting with room to add others there later.
Not sure about the layout but it's workable.